docs(readme): doc for lua_kong_set_static_tag #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flrgh
reviewed
Oct 24, 2022
flrgh
approved these changes
Oct 24, 2022
fffonion
reviewed
Oct 31, 2022
|
|
||
| Add a static tag string for Nginx's `location`(http subsystem) or `server`(stream subsystem) block, | ||
| which can be accessed in Lua land by [`resty.kong.tag.get`](#restykongtagget). | ||
|
|
There was a problem hiding this comment.
Let's decribe the scope of this tag, it can just reflect the behaviour we observed in tests (derive from server block to location, isolate beteen locations, works in nested location, doesn't work in sub query etc)
There was a problem hiding this comment.
Add some description.
Another thing, this directive only works in http/location or stream/server, we can not define tags in http/server now. so no deriving from server block.
fffonion
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add directive and API description for PR #41.