Corrected distinct option

[jbgomond]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes

Fix of the DISTINCT option.

Since 1.3.0 (this commit 861c2a0), the distinct option doesn't have the same effect.

Before 1.3.0

distinct: false

distinct: true

---

1.3.3 without correction

distinct: false

distinct: true

---

1.3.3 with correction

distinct: false

distinct: true

See doctrine documentation : http://doctrine-orm.readthedocs.org/en/latest/tutorials/pagination.html

[salemgolemugoo]

I have the same issue. @pilot @stloyd pls check and merge

[afranioce]

+1

[jbgomond]

Waiting for me ?

[dextervip]

Any updates?

[l3pp4rd]

can you rebase?

[W0rma]

@MJBGO Can you please rebase in order to get this PR merged?

[jbgomond]

Yes sorry I'll do it this week

[W0rma]

Any updates @MJBGO ?

[jbgomond]

Yes, very sorry. I'll do it this week for sure :)

[jbgomond]

Fresh commit done !

I've corrected the problem like explained in the initial message (I've updated with detailed queries).
Doctrine uses $fetchJoinCollection in order to know if the query is a collection or not (true by default) and modifies the number of query generated (3 if false, 4 if true).

The patch that came with 1.3.0 doesn't use the distinct option entirely as seen on the screenshots.
If you think there's a better solution, tell me :)

[W0rma]

@l3pp4rd Could you please review?