Automate filter input type creation #2861
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers currently need to manually specify input types in our GraphQL schema file, requiring field names and column mappings to be duplicated. While it's merely a nuisance at the moment, this approach will be completely inadequate once we introduce the ability to filter by relationship existence. This PR cleans up the developer experience by automatically generating filter input types and guessing the input type needed for a filter directive in most cases. That means all developers need to do is add
@filterable
and@filter
directives to fields and everything just works. Pretty neat!An additional benefit of autogenerating everything is that validation can be added automatically as well. That means that users will now see a validation error when trying to create an invalid filter like this:
This validation improvement resolves the issues remaining after #2860.