Move simple legacy tests out of the critical path #2791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large portion of the test suite is a linear chain of legacy tests with confusing and intertwined dependencies. Every test which can be run in parallel with other tests reduces the total running time by an equivalent amount of time. This PR leaves a handful of simple tests in place, but changes anything which depends upon them to instead depend upon the prior test, taking them out of the critical path and allowing them to run in parallel with the rest of the test suite. The goal is to do this to more tests, but doing so is a time consuming process. I plan make a series of separate PRs to continue this effort in the future. In total, these changes should reduce the total CI running time by 20-30 seconds.