Skip to content

Conversation

zackgalbreath
Copy link
Contributor

After #2524 we started seeing 404 errors when attempting to load 3rdparty.min.js and legacy_1stparty.min.js for Angular and Vue pages.

The solution is to meticulously wrap all our calls to mix() in asset().

After #2524 we started seeing 404 errors when attempting to load
3rdparty.min.js and legacy_1stparty.min.js for Angular and Vue pages.

The solution is to meticulously wrap all our calls to mix() in asset().
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fix for the same issue was included in #2560. Given that #2560 should be merged relatively soon, do you want to make this fix separately or wait for the larger refactor?

@zackgalbreath
Copy link
Contributor Author

A fix for the same issue was included in #2560. Given that #2560 should be merged relatively soon, do you want to make this fix separately or wait for the larger refactor?

I'm okay with deferring to #2560 if that's due to land soon.

@williamjallen williamjallen deleted the asset_mix_cdash_subdir branch November 13, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants