Add SketchVar AST node #8186
Draft
Add SketchVar AST node #8186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodSpeed Instrumentation Performance ReportMerging #8186 will not alter performanceComparing Summary
|
jtran
force-pushed
the
jtran/sketch-ast
branch
2 times, most recently
from
a00a059 to
83ee40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #8171. Part of #8143.
This adds
SketchVarvariant toExpr. It has an optional numeric literal representing the initial value. The placeholder syntax we've been using for this isvar 2.5mm. The optional literal is to allow usingvarwithout a literal.Parsing is not done yet.