Skip to content

Conversation

jtran
Copy link
Contributor

@jtran jtran commented Aug 29, 2025

foo(one(), x = two(), y = three())

Before, unlabeled args like one() would get executed after labeled arguments two() and three(). Execution order was:

  1. two()
  2. three()
  3. one()
  4. foo

This PR makes it in left-to-right order.

  1. foo
  2. one()
  3. two()
  4. three()

This is a breaking change due to things like #2728, but I don't think many KCL programs rely on the current behavior. I think it's worth it to change.

Copy link

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
modeling-app Ready Ready Preview Comment Aug 30, 2025 0:27am

@jtran jtran marked this pull request as ready for review August 29, 2025 21:15
@jtran jtran requested a review from a team as a code owner August 29, 2025 21:15
Copy link

codspeed-hq bot commented Aug 29, 2025

CodSpeed Instrumentation Performance Report

Merging #8184 will not alter performance

Comparing jtran/fix-unlabeled-order (db258da) with main (c13deac)

Summary

✅ 89 untouched benchmarks

@jtran jtran force-pushed the jtran/fix-unlabeled-order branch from ea06f65 to 3dad2f9 Compare August 29, 2025 23:56
@jtran jtran merged commit bcb6ed2 into main Aug 30, 2025
77 of 78 checks passed
@jtran jtran deleted the jtran/fix-unlabeled-order branch August 30, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants