fix(terminal): add timeout and fallback mechanisms for shell execution completion #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…n completion Add timeout handling to prevent terminal processes from hanging indefinitely when shell execution complete events are not received. Implement fallback completion detection that resolves with default exit code after timeout. Change error logs to warnings in TerminalRegistry to allow recovery from inconsistent terminal states. Include comprehensive test coverage for timeout scenarios and fallback completion behavior.
PierrunoYT
force-pushed
the
clean-upstream-main
branch
from
a23fc42 to
68ba20a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timeout and fallback mechanisms for shell execution completion in the terminal integration to improve reliability and prevent hanging processes.
Potentially fixes: #895