Skip to content

add option to auto approve command from now on #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

add option to auto approve command from now on #940

wants to merge 5 commits into from

Conversation

markijbema
Copy link
Collaborator

@markijbema markijbema commented Jul 1, 2025 •
edited
Loading

image

So basically I added an extra option to auto approve, and added some code to extract the "generic" command, see https://github.com/Kilo-Org/kilocode/pull/940/files#diff-e4186e1db216d5c054a1c1db697d1d458058f89efb6e6192c2fd4ac9973c51aaR3

This is all vibecoded, just as a PoC; I'll look into the code more thoroughly myself. I'd like feedback on:

  • What ui do we want? Do we want it to be a button? Does someone have a suggestion of how it should look? (UI's are not really my forte ;) )
  • Do we want generalization, and how much? Any favourite commands i should add and disect?

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2025

⚠️ No Changeset found

Latest commit: 4309c05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

markijbema
markijbema commented Jul 1, 2025
View reviewed changes
webview-ui/src/utils/__tests__/commandPattern.spec.ts
expect(extractCommandPattern("cd /path/to/project && npm install")).toBe("cd && npm install")
expect(extractCommandPattern("git status")).toBe("git status")
expect(extractCommandPattern("ls -la /some/path")).toBe("ls -la")
expect(extractCommandPattern("npm test -- --coverage")).toBe("npm test")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this needs refinement, especially the cd && stuff, but I do think we need something to generalize

@markijbema
Copy link
Collaborator Author

I'm going to leave this for a bit, but since Roo Code is also working on this ( RooCodeInc/Roo-Code#5322 ) I expect to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markijbema