fix(vscode): show default fallback model in small model selector when not configured#8088
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
fix(vscode): show default fallback model in small model selector when not configured#8088kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
… not configured Display 'kilo-auto/small (default)' as an italic placeholder in the small model selector trigger when no model is explicitly configured, so users can see which model is actually being used for background tasks. Closes #8087
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| clearLabel={language.t("settings.providers.notSet")} | ||
| clearLabel={language.t("settings.providers.smallModel.notSet")} | ||
| includeAutoSmall | ||
| placeholder={language.t("settings.providers.smallModel.default")} |
Contributor
Author
There was a problem hiding this comment.
WARNING: Unset small model is not always kilo-auto/small
This placeholder (and the matching clear label above) describes small_model = null as a fixed fallback, but the backend does not work that way. Provider.getSmallModel(defaultModel.providerID) first tries a provider-specific small model, and only falls back to kilo-auto/small in some Kilo paths. Users with Anthropic/OpenAI defaults will see misleading copy here.
Contributor
Author
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.4-20260305 · 859,149 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kilo-auto/small (default)as a greyed-out italic placeholder in the small model selector when no model is explicitly configuredNot set (use kilo-auto/small)so users understand what happens when they clear their selectionplaceholderprop toModelSelectorBasefor reuse by other selectors that need similar default-fallback UXCloses #8087
Changes
model-selector-utils.tsbuildTriggerLabel()accepts optionalplaceholderparam, used whenallowClearis true and no value is selectedModelSelector.tsxModelSelectorBasePropsgainsplaceholderprop; trigger label renders with italic/opacity style when showing placeholderModelsTab.tsxplaceholderand updatedclearLabelto the small model selectoren.tssettings.providers.smallModel.defaultandsettings.providers.smallModel.notSeti18n stringsmodel-selector-utils.test.tsbuildTriggerLabelHow it works
When
small_modelconfig isnull/undefined:kilo-auto/small (default)in italic at 60% opacity — visually distinct from an explicitly selected modelNot set (use kilo-auto/small)instead of the genericNot set (use server default)When a model is explicitly selected, the trigger renders normally (no italic, full opacity).