feat(ui):Add max cost auto-approval setting similar to max requests #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 11, 2025 10:49
The `MaxRequestsInput` component was extracted from `AutoApproveMenu.tsx` into its own file (`MaxRequestsInput.tsx`) to improve reusability and maintainability. This component is now used in both `AutoApproveMenu.tsx` and `AutoApproveSettings.tsx` to manage the auto-approve API request limit. Previously this option was only available in the Chat Approval popup menu
…tsx` into its own file (`MaxRequestsInput.tsx`) to improve reusability and maintainability. This component is now used in both `AutoApproveMenu.tsx` and `AutoApproveSettings.tsx` to manage the auto-approve API request limit. Previously this option was only available in the Chat Approval popup menu
- Add FormattedInput<T> component with InputFormatter interface - Include pre-built formatters: integer, currency, unlimited integer, positive integer - Add specialized CostInput and NumericInput components - Refactor MaxRequestsInput to use new FormattedInput system - Add comprehensive test suite with 16 tests covering all formatters - Reduce MaxRequestsInput from 51 to 33 lines by removing custom parsing logic
Introduces a new setting, `allowedMaxCost`, allowing users to define a maximum API cost before requiring approval to continue a task. This enhances cost control for AI interactions.
- **packages/types**: Added `allowedMaxCost` to `globalSettingsSchema`.
- **src/core/task/Task.ts**: Implemented logic to track and enforce the `allowedMaxCost` within tasks.
- **src/core/webview**: Integrated `allowedMaxCost` into `ClineProvider` and `webviewMessageHandler` for state management and communication.
- **src/shared**: Updated `ExtensionMessage` and `WebviewMessage` types to include `allowedMaxCost`.
- **webview-ui**:
- Added `MaxCostInput` component for UI input.
- Integrated `MaxCostInput` into `AutoApproveMenu` and `AutoApproveSettings`.
- Updated `ExtensionStateContext` to manage the new setting.
- Added internationalization (i18n) strings for `apiCostLimit` across all supported languages.
Removed `positiveIntegerFormatter` as `integerFormatter` can serve the same purpose with appropriate usage. Cleaned up comments in `FormattedInput.tsx` and `MaxCostInput.tsx` for better readability.
|
hassoncs
force-pushed
the
add-max-costs-to-approval-settings
branch
from
5188ed1 to
f59c0d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.