Skip to content

Use light and dark icons where appropriate #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chrarnoldus
Copy link
Contributor

@chrarnoldus chrarnoldus commented Jul 7, 2025

Potentially fixes #1125

These icons look quite different (there's no square around them).

@chrarnoldus chrarnoldus requested a review from Copilot July 7, 2025 12:28
Copy link

changeset-bot bot commented Jul 7, 2025

⚠️ No Changeset found

Latest commit: 93e8078

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the UI icons to use SVG variants for light and dark themes in the Activity Bar and a webview panel.

  • Swapped the default PNG icon for separate light and dark SVG icons in package.json
  • Updated the iconPath in registerCommands.ts to reference the new SVG icon files

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/package.json Changed contribution icon to kilo-light.svg and added darkIcon
src/activate/registerCommands.ts Updated newPanel.iconPath to use kilo-light.svg and kilo-dark.svg

@kevinvandijk
Copy link
Collaborator

Can you double check if this is allowed in the MS Marketplace. I seem to remember there was something about marketplace only allowing PNGs or something like that but that might have been specific to the root icon field. Just to make sure this change won't be rejected from the marketplace.

@hassoncs
Copy link
Contributor

hassoncs commented Jul 7, 2025

Ah, yeah I used these icons for the "git commit generation " buttons, but they don't have the squares like you said!
Maybe make a light version of the current square one? It should be as easy as just changing the SVG fill somewhere

This seems to work for Roo, so we should copy what they do(o)!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Icon does not adapt to light/dark themes
3 participants