Skip to content

Fix https://github.com/Kiln-AI/Kiln/discussions/1224#1227

Merged
scosman merged 1 commit into
mainfrom
scosman/windows_install_path
Apr 4, 2026
Merged

Fix https://github.com/Kiln-AI/Kiln/discussions/1224#1227
scosman merged 1 commit into
mainfrom
scosman/windows_install_path

Conversation

@scosman

@scosman scosman commented Apr 4, 2026

Copy link
Copy Markdown
Collaborator

Allow installing anywhere on Windows

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Windows installer now displays the directory selection page, allowing users to choose their installation location during setup.

Allow installing anywhere
@scosman scosman merged commit 24d6488 into main Apr 4, 2026
13 of 14 checks passed
@coderabbitai

coderabbitai Bot commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7b779db6-0a18-4acb-b926-cacb0af24810

📥 Commits

Reviewing files that changed from the base of the PR and between 4a2fd95 and f4eb635.

📒 Files selected for processing (1)
  • app/desktop/WinInnoSetup.iss

📝 Walkthrough

Walkthrough

The Windows installer configuration removes the DisableDirPage=yes directive from the Inno Setup script, re-enabling the directory selection page during installation while maintaining all other existing configuration settings.

Changes

Cohort / File(s) Summary
Installer Configuration
app/desktop/WinInnoSetup.iss
Removed DisableDirPage=yes from the [Setup] section, re-enabling the directory selection dialog during Windows installation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single line departs with grace,
The installer finds its proper place,
No longer hidden from the sight,
Users choose their path so right! 💾

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch scosman/windows_install_path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the Windows Inno Setup configuration by removing the DisableDirPage=yes directive, which enables the directory selection page during installation and allows users to choose a custom installation path. I have no feedback to provide as there are no review comments.

@github-actions

github-actions Bot commented Apr 4, 2026

Copy link
Copy Markdown

📊 Coverage Report

Overall Coverage: 91%

Diff: origin/main...HEAD

No lines with coverage information in this diff.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant