-
Notifications
You must be signed in to change notification settings - Fork 449
build: Update to header 1.4.327 #10704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI Vulkan-ValidationLayers build queued with queue ID 534496. |
CI Vulkan-ValidationLayers build # 21031 running. |
# | ||
# If working with unreleased extensions, make sure the header and validation version are all on the same header version | ||
project(VVL VERSION 1.4.326 LANGUAGES CXX) | ||
project(VVL VERSION 1.4.327 LANGUAGES CXX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charles-lunarg your python logic worked, congratz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
(helps that the code has been in Vulkan-Loader for a while now)
CI Vulkan-ValidationLayers build # 21031 failed. |
case spv::OpCooperativeVectorLoadNV: | ||
case spv::OpReportIntersectionKHR: | ||
case spv::OpRayQueryGetIntersectionTriangleVertexPositionsKHR: | ||
case spv::OpRayQueryGetClusterIdNV: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikes-lunarg so this blew things up KhronosGroup/SPIRV-Headers@01e0577
I bet you have the latest spirv-headers, you need to update it in known_good.json
too or regenerate with the older spirv headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple weeks without a header update and I forget how to do it properly
c1a6cec
to
758b863
Compare
CI Vulkan-ValidationLayers build queued with queue ID 534548. |
CI Vulkan-ValidationLayers build # 21032 running. |
CI Vulkan-ValidationLayers build # 21032 passed. |
No description provided.