Skip to content

Fix a typo when checking for Khiops compatibility on the use_complement_as_test feature #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

tramora
Copy link
Collaborator

@tramora tramora commented Jul 25, 2025

Fixes the issue #436

It may be worth adding a UT to test thoroughly the private function _preprocess_task_arguments (as it was first attempted in the discarded PR #230)


TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do a more comprehensive update, according to the comment in the review.

@tramora tramora force-pushed the 436-version-compat-use-complement-as-test branch from 31a1534 to 585587a Compare July 30, 2025 14:39
@tramora tramora requested a review from popescu-v July 30, 2025 14:42
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor changes: use string interpolation in report names everywhere (see comments).

@tramora tramora force-pushed the 436-version-compat-use-complement-as-test branch from 585587a to 137b341 Compare July 31, 2025 14:31
@tramora tramora requested a review from popescu-v July 31, 2025 14:31
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popescu-v popescu-v linked an issue Jul 31, 2025 that may be closed by this pull request
@tramora tramora merged commit 583ef07 into dev-v10 Aug 4, 2025
19 checks passed
@tramora tramora deleted the 436-version-compat-use-complement-as-test branch August 4, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid version checks
2 participants