Delombok source code jar #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Found error message around @nonnull changed to non-null. Adjusted relevant tests for this.
senderic
force-pushed
the
delombok-source-jar
branch
from
44331b7 to
0546fcc
Compare
ydnath
reviewed
Jul 19, 2022
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| <groupId>net.juniper.netconf</groupId> | |||
| <artifactId>netconf-java</artifactId> | |||
| <version>2.1.1.6-SNAPSHOT</version> | |||
| <version>2.1.1.6.2-eks</version> | |||
There was a problem hiding this comment.
Is this final code? or still in the draft? what is 'eks'?
There was a problem hiding this comment.
I added the -eks so that I could reference this code in my own project without intersecting with your published artifacts (at least until you merge in my changes). Yes this is in a final state
peterjhill
approved these changes
Jul 21, 2022
|
Oh hey! I forgot to mention, the suffix Should be changed to: Made a PR for this: #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to de-lombok the source code jar so that IDE's can properly dive in.
See https://stackoverflow.com/a/52362427/1582712
Until accepted by Juniper, I added the code to my jitpack: https://jitpack.io/#esend7881/netconf-java/v2.1.1.6.2-eks
If this is accepted by Juniper, be sure to remove the
-ekssuffix.