Hotfix on pem key authentication. Also, Updated exception class. #43
Conversation
senderic
commented
Feb 6, 2021
senderic
commented
- Swapped lines loading private key and connection appears to work now
- Updated exceptions to see more detailed stacktrace.
- Implementing integration test classes
- Bumped version to 2.1.1.3 to distinguish in nexus
| .hostName("localhost") | ||
| .userName(System.getProperty("user.name")) | ||
| .keyBasedAuthentication(true) | ||
| .pemKeyFile("/home/vagrant/.ssh/netconf_rsa") |
There was a problem hiding this comment.
usually tests have to work on any computers for any users. can I ask how this test can work successfully on my computer?
There was a problem hiding this comment.
yep.. for our own team and usage of this library, we have our own integration test, but it is not in the netconf library code.. it is in the code we wrap around the library.
I could see having something like this in the sample code directory in this repo. There may already be something like this. If you wanted to add more samples, that could be interesting.
| @@ -246,12 +246,12 @@ private Session loginWithPrivateKey(int timeoutMilliSeconds) throws NetconfExcep | |||
| try { | |||
| Session session = sshClient.getSession(userName, hostName, port); | |||
| session.setConfig("userauth", "publickey"); | |||
| session.setConfig("StrictHostKeyChecking", "no"); | |||
| session.setConfig("StrictHostKeyChecking", isStrictHostKeyChecking() ? "yes" : "no"); | |||
There was a problem hiding this comment.
it seems to me you forgot to add isStrictHostKeyChecking() method
There was a problem hiding this comment.
That method is auto-generated by lombok. It will compile
There was a problem hiding this comment.
oh, I see. I missed that, sorry. What about IT?
senderic
force-pushed
the
master
branch
2 times, most recently
from
0fb5310 to
8e3701d
Compare
|
I just added a function to run |
|
I agree - I will update the error message and also remove my IT folder. I can keep that stuff on my local repo, no need to bother this one :) |
|
@esend7881 @peterjhill is this good for merging (are all the review comments incorporated)? |
- Squashed a few commits.. - Removed my Integration Tests and removed pemkey file from error message - Added a getRunningConfigAndState call - Allows for netconf <get> requests - https://datatracker.ietf.org/doc/html/rfc6241#section-7.7 - Allows for a filter to be specified. Filter must be of the form <filter>...</filter> or null/blank. - Hotfix on pem key authentication. Also, Updated exception class. - Swapped lines loading private key and connection appears to work now - Updated exceptions to see more detailed stacktrace. - Implementing integration test classes - Bumped version to 2.1.1.4 to distinguish in nexus - Removed log4j.properties from src/main but left it in src/test
