Skip to content

Added maven wrapper and renamed resource folder #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020

Conversation

senderic
Copy link
Contributor

I noticed that with the capitalized Resource folder, maven install did not pick up on the files in that folder. By naming it with proper capitalization, maven works just fine.

(It is possible people who ran maven through intellj or eclipse did not notice that due to the IDE doing work)

@senderic senderic changed the title Added maven wrapped and renamed resource folder Added maven wrapper and renamed resource folder May 14, 2020
Copy link
Contributor

@peterjhill peterjhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the .mvn directory to your .gitignore and remove them from pull request commit.

Copy link
Contributor

@peterjhill peterjhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darn mac and its case insensitive file system! good catch.

Once all the .mvn and mvnw.cmd is pulled out of commit I'll send an email to someone in Juniper whom I hope is still there who has commit privileges...

cheers!

@senderic
Copy link
Contributor Author

Many projects do come with a maven wrapper (so the user doesn't need a global install of maven). In fact, all gradle projects have a gradle wrapper. Are you sure you don't want them included?

… up on files in that Resource folder). Also added maven wrapper
@peterjhill
Copy link
Contributor

ah, okay.. I'm constrained by what I've seen. I have not used gradle yet and have always needed to have maven installed.

I'll send an email out to the people at Juniper that helped me get my PR merged and let them know that this is here.

@senderic
Copy link
Contributor Author

@peterjhill - cool, no problem. You can use the maven wrapper by doing a ./mvnw install instead of the global mvn install

A caveat, you must have the JAVA_HOME variable set up and pointing to your jdk folder.

It's pretty neat and in the end, allows people to only need Java installed instead of Java + (your required version of) Maven.

@ydnath ydnath merged commit a8ede64 into Juniper:master May 18, 2020
@ydnath ydnath mentioned this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants