NETCONF RFC6241 and RFC6242 conformance fixes #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. xml version conformance . hello message conformance . rpc message conformance . framing protocol conformance - Extracting reused strings to constants - updated gitignore
peterjhill
suggested changes
Jul 12, 2019
There was a problem hiding this comment.
Adding the constant class is great. Thanks for cleaning up some of the whitespace.
I can't approve merges, so I'm only offering my opinions. I can reach out to the people who can do merges.
You also should probably bump the minor version in the pom.xml to 2.0.1.
Cheers!
|
P.S. The commit message is awesome! |
- fixed broken idents caused by auto-formatting
|
@peterjhill Thank you for your comments Peter! I changed the code to single imports and fixed the indention issues as well as bumping the minor version to 2.0.1 |
peterjhill
approved these changes
Jul 15, 2019
|
Congrats @jonasglass on your first github PR! |
|
@peterjhill Thank you for the motivational hints and messages Peter! Nice to see such friendly community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NETCONF RFC6241 and RFC6242 conformance fixes
XML Version Conformance (RFC6241 Section 3)
Added XML declaration before every NETCONF message
Hello Message Conformance (RFC6241 Section 8.1)
Fixed wrong URN in hello message xmlns and capability (using 1.0 of course)
RPC message conformance (RFC6241 Section 4.1)
Added the message-id element to RPCs. Also added XML NS to RPC as an attribute since it is present in all standards and most implementations.
Framing Protocol Conformance (RFC6242 Section 4.1)
The device prompt (
]]>]]>) signals the end of a NETCONF message. In the current implementation the device prompt was only detected if it was followed by a \n sincereadLine()was used. This is not in conformance to the RFC. I changed it to reading character by character so that the end of a NETCONF message is also detected if the prompt is not being followed by a line break.Using UTF8 encoding (RFC6241 Section 3)
Changed encoding and decoding to force-use UTF-8 instead of system default.
Extracting reused strings
Extracted constants which have been used in multiple places and classes to a seperate class.
Added debugging
Added debug-logging upon receiving of a NETCONF messages. Currently it was only logged when sending a NETCONF message.
Updated gitignore
Added IntelliJ folders to git ignore.