Update ngramizer.jl #148
Merged
Update ngramizer.jl #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eulerkochy
reviewed
Apr 26, 2019
| for index in 1:(n_words - n + 1) | ||
| token = join(words[index:(index + n - 1)], " ") | ||
| tokens[token] = get(tokens, token, 0) + 1 | ||
|
|
There was a problem hiding this comment.
Also, imo the Travis CI is reporting an error due to change in implementation. Have a look at the tests corresponding to this change.
|
Thank you so much for this. May you please, update the documents and add the tests as well? |
Reflects changes made to ngrams() for n>1.
Reflects changes made to ngrams() for n greater than 1
|
Updated Tests and Documentation to reflect the changes. |
|
That could have been better implemented as an option IMO. Or by having a variant of |
|
We could open an issue for the same should be good first PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous function returned all the ngrams from n to 1.
This error is also recorded in the documentation.