Switch to Project.toml and workflows #51
Conversation
|
Can someone from @JuliaStats merge this PR? The changes are all generic upgrading to Project.toml stuff. |
|
@ararslan - you probably better understand this kind of changes than me. Can you please have a look? Thank you! |
|
Looks good, but the |
|
You got it! Thanks for reviewing. |
Project.toml
Outdated
| IterTools = "1.3" | ||
| Reexport = "1.2" |
There was a problem hiding this comment.
| IterTools = "1.3" | |
| Reexport = "1.2" | |
| IterTools = "1" | |
| Reexport = "1" |
I imagine v1.0 and v1.1 of those packages would also work. For StatsBase, I'm not sure what an appropriate bound is; the most recent might be similarly too restrictive. Do the tests pass for you with the latest StatsBase version? Looks like CI isn't running, I guess because this PR is adding CI configuration from a fork.
There was a problem hiding this comment.
Yep I tested with v1.0 for those two.
It runs fine with StatsBase v0.33.10 (latest). Its v0.33.1 is a year old, so I think setting its compat at "0.33" is fine.
There was a problem hiding this comment.
I didn't realize 0.33 was that old. That's fine then.
|
Thanks! |
|
Thank you! Can you register it? |
This package's code actually seems to run fine in julia 1.6, but needs some TLC.
This PR switches its REQUIRE file to Project.toml and replaces travis-ci with github workflows for CI and for TagBot.
After this is tagged, it should allow JuliaStats/Lasso.jl#62 to proceed