Skip to content

Split jth_hess_residual into coord and structure functions #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2025
Merged

Split jth_hess_residual into coord and structure functions #502

merged 2 commits into from
Jul 27, 2025

Conversation

arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Jul 12, 2025 •
edited
Loading

  • Add jth_hess_residual_coord and jth_hess_residual_coord! functions
  • Update jth_hess_residual to use coordinate-based approach
  • Add missing hprod_residual and hess_op_residual functions
  • Update documentation to include new functions

Fixes #466

@arnavk23
Split jth_hess_residual into coord and structure functions
2f57d89 
- Add jth_hess_residual_coord and jth_hess_residual_coord! functions
- Update jth_hess_residual to use coordinate-based approach
- Add missing hprod_residual and hess_op_residual functions
- Update documentation to include new functions
- Fixes JuliaSmoothOptimizers#466
@tmigot tmigot self-requested a review July 14, 2025 11:28
tmigot
tmigot requested changes Jul 23, 2025
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 ! Please avoid modifying code that is unrelated to the PR aim.

@arnavk23 arnavk23 requested a review from tmigot July 25, 2025 13:00
@arnavk23
Copy link
Contributor Author

@tmigot All test pass.

tmigot
tmigot approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23

@tmigot tmigot merged commit 796adbd into JuliaSmoothOptimizers:main Jul 27, 2025
72 of 73 checks passed
@arnavk23 arnavk23 deleted the remove branch July 27, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmigot tmigot tmigot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split jth_hess_residual in coord and structure
2 participants
@arnavk23 @tmigot