Add Project.toml #674
Add Project.toml #674
Conversation
| @@ -0,0 +1,15 @@ | |||
| name = "PyCall" | |||
| uuid = "438e738f-606a-5dbb-bf0a-cddfbfd45ab0" | |||
| authors = ["Steven G. Johnson <[email protected]>", "Yichao Yu <[email protected]>", "Takafumi Arakaki <[email protected]>", "Simon Kornblith <[email protected]>", "Páll Haraldsson <[email protected]>", "Jon Malmaud <[email protected]>", "Jake Bolewski <[email protected]>", "Keno Fischer <[email protected]>", "Joel Mason <[email protected]>", "Jameson Nash <[email protected]>", "The JuliaPy development team"] | |||
There was a problem hiding this comment.
Not sure what to do here. The list of authors is taken from top 10 git log --format='%aN <%aE>' | sort | uniq -c | sort -nr. I then appended "The JuliaPy development team".
|
|
||
| [compat] | ||
| Conda = "1.0" | ||
| MacroTools = "≥ 0.4" |
There was a problem hiding this comment.
It seems MacroTools 0.4 worked with Julia 0.7 nightly https://travis-ci.org/MikeInnes/MacroTools.jl/builds/288579177. So if we say julia = "0.7, 1.0" I think it makes sense to allow MacroTools 0.4. Alternatively, we can do MacroTools = "0.4, 0.5" but it then makes this version of PyCall incompatible with MacroTools 0.6 and above.
Project.toml
Outdated
| name = "PyCall" | ||
| uuid = "438e738f-606a-5dbb-bf0a-cddfbfd45ab0" | ||
| authors = ["Steven G. Johnson <[email protected]>", "Yichao Yu <[email protected]>", "Takafumi Arakaki <[email protected]>", "Simon Kornblith <[email protected]>", "Páll Haraldsson <[email protected]>", "Jon Malmaud <[email protected]>", "Jake Bolewski <[email protected]>", "Keno Fischer <[email protected]>", "Joel Mason <[email protected]>", "Jameson Nash <[email protected]>", "The JuliaPy development team"] | ||
| version = "1.91.2-DEV" |
There was a problem hiding this comment.
version is somewhat random, too
There was a problem hiding this comment.
I'm confused by the release process with a Project.toml. Do we update the version and then tag a release? In which case the version here should be the last released/tagged version?
There was a problem hiding this comment.
I think this is a good quick summary https://discourse.julialang.org/t/22677/32
But first you need to install the Registrator app https://github.com/apps/registratortest/installations/new (see https://github.com/JuliaComputing/Registrator.jl)
Do we update the
versionand then tag a release?
I think we update version in Project.toml and comment @JuliaRegistrator `register()` in github. Adding a Git tag is optional but I think it's better to do that.
In which case the
versionhere should be the last released/tagged version?
Yeah, I think that's a valid option too. I'll change it.
|
I guess we should delete REQUIRE now? |
We'll need a
Project.tomlfor the next release https://discourse.julialang.org/t/22677