Skip to content

[Runner] Make clang_use_lld a keyword argument #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2023
Merged

[Runner] Make clang_use_lld a keyword argument #357

merged 1 commit into from
Dec 29, 2023

Conversation

giordano
Copy link
Member

I need to do more testing (hence opening as draft), but this might be sufficient to let users set clang_use_lld as keyword argument to BinaryBuilder.build_tarballs, so that they can easily opt-out of it.

@giordano giordano requested a review from gbaraldi December 28, 2023 21:56
@giordano
Copy link
Member Author

giordano commented Dec 29, 2023 •
edited
Loading

Ok, I confirm the change I proposed in this PR is indeed enough here in BinaryBuilderBase, but we need another small change in BinaryBuilder so that we can use the new keyword argument in BinaryBuilder.build_tarballs. Edit: JuliaPackaging/BinaryBuilder.jl#1310.

@giordano
Copy link
Member Author

The test failure on nightly is unrelated to this PR and it's caused by this new warning being printed by Pkg:

┌ Warning: Circular dependency detected. Precompilation will be skipped for:
│   Downloads [f43a241f-c20a-4ad4-852c-f6b1247861c6]
│   Pkg [44cfe95a-1eb2-52ea-b672-e2afdf69b78f]
│   p7zip_jll [3f19e933-33d8-53b3-aaab-bd5110c3b7a0]
│   MozillaCACerts_jll [14a3606d-f60d-562e-9121-12d972cd8159]
│   LibCURL [b27032c2-a3e7-50c8-80cd-2d36dbcbfd21]
└ @ Pkg.API ~/repo/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:1260

This CI job back on November 29th 2023 was successful.

@giordano giordano mentioned this pull request Dec 29, 2023
Open
@giordano giordano marked this pull request as ready for review December 29, 2023 14:55
@giordano giordano force-pushed the mg/clang-use-lld branch 3 times, most recently from bb05aa4 to 95af4bc Compare December 29, 2023 15:15
@giordano giordano merged commit 94b0852 into master Dec 29, 2023
@giordano giordano deleted the mg/clang-use-lld branch December 29, 2023 16:08
@giordano giordano mentioned this pull request Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbaraldi gbaraldi Awaiting requested review from gbaraldi

Assignees
No one assigned
Labels
runner 🏃‍♀️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@giordano