Rebased PR #99 #102
Merged
Rebased PR #99 #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is confusing that `constructorof` is documented as returning the constructor of `T`, which is normally defined to be `T`, and then typically does not return `T`, and so does not usually construct `T`. However, this PR is intended just to remove the undefined behavior here of using an unsound generated function (examining mutable state with getfield).
|
IMO:
|
|
I suppose this should be OK to merge now. The failing Accessors test certainly seems like something that would be flaky (speed measurement, approximate floating point comparison), while the others also fail in empty PR #103. |
|
We can drop old Julia versions. I reran the Accessors/pre benchmark a few times and the error persisted. So I don't think it is just noise but a real regression. However, it is not a super important regression that necessarily blocks this PR. |
|
The Accessors/pre benchmark failure reproduces without this PR on v1.12.0-beta4. |
|
Dropping pre 1.10 is fine with me |
jw3126
approved these changes
Jun 8, 2025
|
Looks like everyone supports this PR, thank you :) Could you please remove the now-unreachable and untestable code? (all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #99 rebased on top of current
master: