-
Notifications
You must be signed in to change notification settings - Fork 63
Fix ALL deprecation warnings on Julia 0.7.0 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Doesn't work.
|
This is related to #66, right? |
src/combinations.jl
Outdated
|
|
||
| Base.start(c::Combinations) = collect(1:c.t) | ||
| function Base.next(c::Combinations, s) | ||
| function Base.iterate(c::Combinations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than copying the code to a separate method, I believe you could just use Base.iterate(c::Combinations, s = collect(1:c.t)). 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!!! For some reason I don't truly understand this actually fixed the problem!
I'll now carry on with the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! The default state (second argument) of the iterate function is supposed to be the initial iteration state, which is what start previously provided.
|
hi!!! I just finished this! Please review and merge as soon as you can! :) |
|
Superseded by #69. Sorry :/ |
|
Nooooo come on people why didn't you say you were working on it... :( |
|
@Datseris Sorry, didn't realize you were trying to update to 0.7 based on previous PR name... should've inferred. 😞 Nicely done, though. |
I started to do this but I need help. I don't know what I am doing wrong, and haven't really understood what Combinatorics actually does. For now whenever I do
[combinations(['a', 'b', 'c'])...]I get:Why is the first element of each "increasing size" become doubled?