Skip to content

Implementation of ImageArray #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 21, 2012
Merged

Implementation of ImageArray #623

merged 18 commits into from
Mar 21, 2012

Conversation

timholy
Copy link
Member

@timholy timholy commented Mar 21, 2012

Initial, but seemingly-decent, implementation of ImageArray.

timholy added 18 commits March 17, 2012 03:05
This does not fix a bug, but it highlights where I think it occurs and
suggests a possible fix for it. I'm not an elisp wizard, so I decided
that discretion was the better part of valor.
This isn't debugged yet because I'm getting a segfault. Committing now so I can merge with master and make sure I'm updated to the latest Julia.
 - This works around some segfaults, probably by being more type-correct.
 - It adds support for a few methods dealing with subscripting.
This will need some main-library changes, because currently there is no deep-copy operation for ranges.
- added isspatial function to easily find spatial coordinates
- remembered to permute the other relevant fields. The hardest part is computing the permutation to be applied to just spatial dimensions, but a little bit of indexing gymnastics seems to do the trick
- Fix one typo that kept the copy operation from working
- Random cleanups to documentation
This also cleans up a few of the comments further
- Support conventional referencing, img[20:100,...]
- Add support for the "size" function
- Clean up the documentation
- Don't deep-copy references, they are immutable (Jeff B)
This passes a simple unit test function I maintain here.
…methods.

Details:
- Value range field added
- Renamed data_size, but changed it to size_ancestor, hoping that is clearer
- Defined new types for color spaces
- Defined sub and assign methods
StefanKarpinski added a commit that referenced this pull request Mar 21, 2012
Implementation of ImageArray
@StefanKarpinski StefanKarpinski merged commit 545fc07 into JuliaLang:master Mar 21, 2012
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Oct 11, 2021
The method exists but it wasn't mentioned.
ViralBShah pushed a commit that referenced this pull request May 17, 2025
Stdlib: SparseArrays
URL: https://github.com/JuliaSparse/SparseArrays.jl.git
Stdlib branch: main
Julia branch: master
Old commit: f3610c0
New commit: 6d072a8
Julia version: 1.13.0-DEV
SparseArrays version: 1.12.0(Does not match)
Bump invoked by: @IanButterworth
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaSparse/SparseArrays.jl@f3610c0...6d072a8

```
$ git log --oneline f3610c0..6d072a8
6d072a8 Lazily init cholmod (#626)
8ff11da fix libsuitesparseconfig bug (#625)
fac1548 lazily init cholmod
75eaa18 fix libsuitesparseconfig bug
7b6e810 Use `libsuitesparseconfig` from JLL (#620)
b225a85 Clarify pros, cons and limitations of Cholesky and LDLt (#621)
3d42644 Update index.md (#623)
16bbcbc 5-term mul! with Diagonal (#603)
d050b1b Relax `eltype` in `Diagonal` `ldiv!`/`rdiv!` (#616)
4968cff `ldiv!` for `Diagonal` and a sparse vector (#613)
5062034 Fix `issymmetric` for matrices with empty columns (#606)
9a46561 Replace `v == zero(v)` with  `_iszero` (#610)
```

Co-authored-by: IanButterworth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants