correctly encode and validate fully_covers as edges #58861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows edges that don't fully cover their method matches to be properly tracked through serialization. When fully_covers is false (indicating incomplete method coverage), we encode the method count as negative in the edges array to signal that compactly.
This commit introduces a new dispatch status bit to track when a method
has other methods that are not more specific than it, enabling better
optimization decisions during method dispatch.
Key changes:
1. Add METHOD_SIG_LATEST_HAS_NOTMORESPECIFIC bit to track methods with
non-morespecific intersections
2. Add corresponding METHOD_SIG_PRECOMPILE_HAS_NOTMORESPECIFIC bit for
precompiled methods
3. Refactor method insertion logic:
- Remove morespec_unknown enum state, compute all morespec values upfront
- Convert enum morespec_options to simple boolean logic (1/0)
- Change 'only' from boolean to 'dispatch_bits' bitmask
- Move dispatch status updates before early continues in the loop
vtjnash
added
don't squash
KristofferC
pushed a commit
that referenced
this pull request
Jul 8, 2025
This is a bugfix and code cleanup, since it wasn't properly encoding and checking for newly "missing"-type backedges `fully_covering` during verification. Co-authored-by: Claude <[email protected]> (cherry picked from commit 6efd218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix and code cleanup, since it wasn't properly encoding and checking for newly "missing"-type backedges
fully_coveringduring verification.(Written with assistance from Claude)