add support for storing just the inferred inlining_cost in CodeInstance #58662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for giving us the option of not storing code that does not seem useful immediately, but which we previously kept around just in case inference or codegen (always_inline) ever needed to decide if it was worthwhile to inline later. And also for investigating issues like the recently closed #58449 to examine whether the code was removed for either heuristic or correctness reasons.
jmert
reviewed
Jun 7, 2025
Co-authored-by: Justin Willmert <[email protected]>
JeffBezanson
approved these changes
Jun 11, 2025
nilesh646
pushed a commit
to nilesh646/julia
that referenced
this pull request
Jun 17, 2025
…ce (JuliaLang#58662) In preparation for giving us the option of not storing code that does not seem useful immediately, but which we previously kept around just in case inference or codegen (always_inline) ever needed to decide if it was worthwhile to inline later. And also for investigating issues like the recently closed JuliaLang#58449 to examine whether the code was removed for either heuristic or correctness reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for giving us the option of not storing code that does not seem useful immediately, but which we previously kept around just in case inference or codegen (always_inline) ever needed to decide if it was worthwhile to inline later. And also for investigating issues like the recently closed #58449 to examine whether the code was removed for either heuristic or correctness reasons.