Define in for CartesianIndex ranges
#58616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
force-pushed
the
jishnub/cartesianindex_in_steprangelen
branch
from
c14852c to
38c0ef1
Compare
|
Ref #57034 This PR seems to reinforce the view that ranges are collections of objects, and not intervals. I'm not sure it's relevant, but I think I remember people being of two minds about this, so I thought I'd mention it. |
|
For what it's worth, this PR was motivated by failing to compute the intersection of these ranges, which is used in checking for aliasing. I believe Closes #57034, and the suggested implementation in that issue is pretty similar to this one. |
mbauman
reviewed
Jun 16, 2025
KristofferC
pushed a commit
that referenced
this pull request
Jul 8, 2025
Currently, this hits a fallback method that assumes that division is defined for the elements of the range. After this, the following works: ```julia julia> r = StepRangeLen(CartesianIndex(1), CartesianIndex(1), 3); julia> r[1] in r true julia> CartesianIndex(0) in r false ``` (cherry picked from commit 24b3273)
KristofferC
pushed a commit
that referenced
this pull request
Jul 8, 2025
Currently, this hits a fallback method that assumes that division is defined for the elements of the range. After this, the following works: ```julia julia> r = StepRangeLen(CartesianIndex(1), CartesianIndex(1), 3); julia> r[1] in r true julia> CartesianIndex(0) in r false ``` (cherry picked from commit 24b3273)
|
Test doesn't pass backported |
KristofferC
added a commit
that referenced
this pull request
Jul 8, 2025
This reverts commit 304847e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this hits a fallback method that assumes that division is defined for the elements of the range. After this, the following works: