Skip to content

Fix signedness typo in world range update #58390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Fix signedness typo in world range update #58390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Compiler/src/abstractinterpretation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3545,7 +3545,7 @@ function merge_override_effects!(interp::AbstractInterpreter, effects::Effects,
# N.B.: We'd like deleted_world here, but we can't add an appropriate edge at this point.
# However, in order to reach here in the first place, ordinary method lookup would have
# had to add an edge and appropriate invalidation trigger.
valid_worlds = WorldRange(m.primary_world, typemax(Int))
valid_worlds = WorldRange(m.primary_world, typemax(UInt))
if sv.world.this in valid_worlds
update_valid_age!(sv, valid_worlds)
else
Expand Down
2 changes: 1 addition & 1 deletion Compiler/src/typeinfer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ function adjust_effects(ipo_effects::Effects, def::Method, world::UInt)
valid_worlds = WorldRange(0, typemax(UInt))
if is_effect_overridden(override, :consistent)
# See note on `typemax(Int)` instead of `deleted_world` in adjust_effects!
override_valid_worlds = WorldRange(def.primary_world, typemax(Int))
override_valid_worlds = WorldRange(def.primary_world, typemax(UInt))
if world in override_valid_worlds
ipo_effects = Effects(ipo_effects; consistent=ALWAYS_TRUE)
valid_worlds = override_valid_worlds
Expand Down