Skip to content

Make trimming tests work in an out-of-tree build. #58340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2025
Merged

Make trimming tests work in an out-of-tree build. #58340

merged 2 commits into from
May 10, 2025

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 7, 2025 •
edited
Loading

... by emulating how the embedding tests work.

@maleadt maleadt requested a review from topolarity May 7, 2025 13:47
@maleadt maleadt added the building Build system, or building Julia or its dependencies label May 7, 2025
@maleadt maleadt marked this pull request as draft May 7, 2025 13:56
@maleadt maleadt force-pushed the tb/oot_trimming branch from affdddd to 58bbb28 Compare May 7, 2025 13:57
@maleadt maleadt marked this pull request as ready for review May 7, 2025 13:58
topolarity
topolarity approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@topolarity topolarity added the merge me PR is reviewed. Merge when all tests are passing label May 7, 2025
@maleadt maleadt marked this pull request as draft May 8, 2025 06:46
@maleadt maleadt force-pushed the tb/oot_trimming branch 2 times, most recently from 17a4bf6 to fa8652e Compare May 8, 2025 13:31
@maleadt maleadt force-pushed the tb/oot_trimming branch from fa8652e to 07ef59b Compare May 9, 2025 08:13
@maleadt maleadt marked this pull request as ready for review May 9, 2025 10:22
@IanButterworth IanButterworth merged commit 6a796e0 into master May 10, 2025
7 checks passed
@IanButterworth IanButterworth deleted the tb/oot_trimming branch May 10, 2025 22:28
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label May 11, 2025
charleskawczynski pushed a commit to charleskawczynski/julia that referenced this pull request May 12, 2025
@maleadt @charleskawczynski
Make trimming tests work in an out-of-tree build. (JuliaLang#58340)
4f8f7f7
charleskawczynski pushed a commit to charleskawczynski/julia that referenced this pull request May 12, 2025
@maleadt @charleskawczynski
Make trimming tests work in an out-of-tree build. (JuliaLang#58340)
1d449dc
@topolarity topolarity added the backport 1.12 Change should be backported to release-1.12 label Jun 27, 2025
topolarity pushed a commit that referenced this pull request Jun 27, 2025
@maleadt @topolarity
Make trimming tests work in an out-of-tree build. (#58340)
4c68379 
(cherry picked from commit 6a796e0)
@topolarity topolarity mentioned this pull request Jun 27, 2025
Merged
60 tasks
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topolarity topolarity topolarity approved these changes

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maleadt @topolarity @giordano @KristofferC @IanButterworth