staticdata: fix many mistakes in staticdata stripping #58166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/staticdata-trim-binding-mistakes
branch
2 times, most recently
from
dc0fd48 to
ab07d2e
Compare
Attempting to prune backedges instead ended up uncovering a lot of number of mistakes in the trim code which became particularly egregious after the BindingPartition additions. This was making the tests result in corrupt results sometimes, depending on the local visitor order. Additionally, need to make sure we respect the `const` flag inside mutable types during serialization (not replacing Ptr values with C_NULL), since inference may rely on that.
vtjnash
force-pushed
the
jn/staticdata-trim-binding-mistakes
branch
from
ab07d2e to
fdba408
Compare
53 tasks
LebedevRI
pushed a commit
to LebedevRI/julia
that referenced
this pull request
May 2, 2025
While JuliaLang#58156 was supposed to be fairly trivial, it ended up uncovering many bugs in the unusual ways that trimming and binding partition had been added to the serialization format. This attempts to reorganize them to be handled more consistently and with fewer mistakes.
KristofferC
pushed a commit
that referenced
this pull request
May 5, 2025
While #58156 was supposed to be fairly trivial, it ended up uncovering many bugs in the unusual ways that trimming and binding partition had been added to the serialization format. This attempts to reorganize them to be handled more consistently and with fewer mistakes. (cherry picked from commit 828e3a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #58156 was supposed to be fairly trivial, it ended up uncovering many bugs in the unusual ways that trimming and binding partition had been added to the serialization format. This attempts to reorganize them to be handled more consistently and with fewer mistakes.