relax dispatch for the IteratorSize method for Generator
#58110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
bugfix
51 tasks
This was referenced Apr 25, 2025
fingolfin
reviewed
May 8, 2025
| @@ -98,7 +98,7 @@ IteratorSize(::Type{Any}) = SizeUnknown() | |||
|
|
|||
| IteratorSize(::Type{<:Tuple}) = HasLength() | |||
| IteratorSize(::Type{<:AbstractArray{<:Any,N}}) where {N} = HasShape{N}() | |||
| IteratorSize(::Type{Generator{I,F}}) where {I,F} = IteratorSize(I) | |||
| IteratorSize(::Type{<:Generator{I}}) where {I} = (@isdefined I) ? IteratorSize(I) : SizeUnknown() | |||
There was a problem hiding this comment.
Apologies for the dumb question, but in which scenario would @isdefined I return false ?
There was a problem hiding this comment.
The bottom type does it:
julia> struct S{P} end
julia> f(::Type{<:S}) = "fallback"
f (generic function with 1 method)
julia> f(::Type{<:S{P}}) where {P} = (@isdefined P) ? "is defined" : "is not defined"
f (generic function with 2 methods)
julia> f(Union{})
"is not defined"@isdefined is often used like that in eltype method definitions.
58 tasks
fingolfin
approved these changes
May 31, 2025
nsajko
force-pushed
the
relax_dispatch_for_Generator_IteratorSize
branch
from
f1dfaaf to
6d55b1e
Compare
|
Rebased to get rid of the merge commit. Not sure, but I think the merge commit could have prevented automatic backport. |
|
Most PRs are squash-merged, there's no merge commit anyway. |
|
I think the autobackport functionality maybe works directly with the PR, not with the squashed commit, though? Again, not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58109