gf.c: Fix backedge de-duplication bug #58106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was checking for the old edge type (MethodInstance) instead of the new one (CodeInstance), causing non-invoke edges to be missed.
vtjnash
reviewed
Apr 14, 2025
|
Thanks for fixing this! |
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
This code was checking for the old edge type (`MethodInstance`) instead of the new one (`CodeInstance`), causing duplicate non-invoke edges to accumulate in our `backedges`.
vtjnash
pushed a commit
that referenced
this pull request
Jun 5, 2025
This code was checking for the old edge type (`MethodInstance`) instead of the new one (`CodeInstance`), causing duplicate non-invoke edges to accumulate in our `backedges`. (cherry picked from commit cf875c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was checking for the old edge type (
MethodInstance) instead of the new one (CodeInstance), causing duplicate non-invoke edges to accumulate in ourbackedges.