Skip to content

Conversation

IanButterworth
Copy link
Member

Fixes #50966

julia> @info "msg" rand(100)
┌ Info: msg
│   rand(100) =
│    100-element Vector{Float64}:
│     0.31865680660524676
│     0.16988153794366578
│     0.3297352714106879
│     0.730095231666752
│     ⋮
│     0.34785788866017486
│     0.8090313673812081
│     0.6264631844074221
└     0.21672825693197895

julia> Base.active_repl.options.iocontext[:displaysize] = (1000, displaysize(stdout)[2])
(1000, 148)

julia> @info "msg" rand(100)
┌ Info: msg
│   rand(100) =
│    100-element Vector{Float64}:
│     0.41144853917376256
│     0.15830792044161057
│     0.021068774824703373
│     0.5992327965202229
│     0.4589906336017341
│     0.9034830653478718
│     0.4327793117273919
│     0.8618775649384036
│     0.8863892401850897
│     0.7298358588615682
│     0.22763664024065244
... (manual truncated.. shows all)

Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./julia  -e 'Base.active_repl'
ERROR: UndefVarError: `active_repl` not defined

I don't think you can change this.

@IanButterworth
Copy link
Member Author

I added an isdefined check. Would that make this ok?

@IanButterworth IanButterworth requested a review from c42f August 18, 2023 15:44
@IanButterworth
Copy link
Member Author

bump @c42f

@IanButterworth
Copy link
Member Author

bump. Hopefully this is a simple approve/reject

@vtjnash vtjnash added the triage This should be discussed on a triage call label Sep 27, 2023
@oscardssmith
Copy link
Member

triage wants to make sure @vtjnash is OK with this. Other than that, approved.

@vtjnash
Copy link
Member

vtjnash commented Oct 2, 2023

I think the main question is whether we want one feature (logging), which has nothing to do with the REPL and is not even an interactive feature, to be dependent on a feature of a different package which usually is not even loaded, but even when loaded might not be active, to change behavior when that other feature in that other package is run?

@IanButterworth IanButterworth marked this pull request as draft June 21, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging The logging framework triage This should be discussed on a triage call
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging doesn't respect active repl iocontext size
3 participants