Skip to content

add docs for getglobal and setglobal! #48409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2023
Merged

add docs for getglobal and setglobal! #48409

merged 4 commits into from
Jan 26, 2023

Conversation

simeonschaub
Copy link
Member

closes #45480

@simeonschaub simeonschaub added backport 1.9 Change should be backported to release-1.9 docs This change adds or pertains to documentation labels Jan 25, 2023
aviatesk
aviatesk reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should help the doctest run successfully.

simeonschaub
simeonschaub commented Jan 26, 2023
View reviewed changes
@simeonschaub simeonschaub added the merge me PR is reviewed. Merge when all tests are passing label Jan 26, 2023
@fonsp
Copy link
Member

fonsp commented Jan 26, 2023

Perhaps we can say atomic ordering instead of ordering? I initially thought that this somehow controls the ambiguous result of getglobal(@__MODULE__, :plot) after running using Plots, Makie 😅

simeonschaub
simeonschaub commented Jan 26, 2023
View reviewed changes
@simeonschaub
Copy link
Member Author

Seems reasonable. Better?

@simeonschaub simeonschaub merged commit 0231c22 into master Jan 26, 2023
@simeonschaub simeonschaub deleted the sds/getsetglobal_docs branch January 26, 2023 20:27
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 27, 2023
KristofferC pushed a commit that referenced this pull request Feb 1, 2023
@simeonschaub @aviatesk @KristofferC
add docs for getglobal and setglobal! (#48409)
9a8599a 
closes #45480

Co-authored-by: Shuhei Kadowaki <[email protected]>
(cherry picked from commit 0231c22)
@KristofferC KristofferC mentioned this pull request Feb 1, 2023
Merged
35 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk approved these changes

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: documentations for getglobal/setglobal!
6 participants
@simeonschaub @fonsp @Keno @aviatesk @KristofferC @DilumAluthge