Skip to content

Fix shell cd error when working dir has been deleted #41244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Fix shell cd error when working dir has been deleted #41244

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3b9b1f6
Update client.jl, for cmd cd
norci Feb 10, 2021
14f8b13
suggestions
IanButterworth Jul 23, 2024
cbaffc2
tests
IanButterworth Jul 23, 2024
855a16e
expand tests
IanButterworth Sep 16, 2024
6cd2320
fixes
IanButterworth Sep 17, 2024
51fa4d4
reset OLDPWD before tests
IanButterworth Sep 17, 2024
7273cbc
more fix (passes locally)
IanButterworth Sep 17, 2024
f7476ef
skip test on windows
IanButterworth Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions base/client.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ function repl_cmd(cmd, out)
if isempty(cmd.exec)
throw(ArgumentError("no cmd to execute"))
elseif cmd.exec[1] == "cd"
new_oldpwd = pwd()
if length(cmd.exec) > 2
throw(ArgumentError("cd method only takes one argument"))
elseif length(cmd.exec) == 2
Expand All @@ -52,11 +51,17 @@ function repl_cmd(cmd, out)
end
dir = ENV["OLDPWD"]
end
cd(dir)
else
cd()
dir = homedir()
end
ENV["OLDPWD"] = new_oldpwd
try
ENV["OLDPWD"] = pwd()
catch ex
ex isa IOError || rethrow()
# if current dir has been deleted, then pwd() will throw an IOError: pwd(): no such file or directory (ENOENT)
delete!(ENV, "OLDPWD")
end
cd(dir)
println(out, pwd())
else
@static if !Sys.iswindows()
Expand Down
17 changes: 17 additions & 0 deletions test/file.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,6 +1908,23 @@ end
end
end

@testset "pwd tests" begin
mktempdir() do dir
cd(dir) do
withenv("OLDPWD" => nothing) do
io = IOBuffer()
Base.repl_cmd(@cmd("cd"), io)
Base.repl_cmd(@cmd("cd -"), io)
@test realpath(pwd()) == realpath(dir)
rm(dir)
@test_throws Base._UVError("pwd()", Base.UV_ENOENT) pwd()
# pwd() throwing was causing this to error
Base.repl_cmd(@cmd("cd \\~"), io)
end
end
end
end

@testset "readdir tests" begin
≛(a, b) = sort(a) == sort(b)
mktempdir() do dir
Expand Down