Fix inlining's rewrite of _apply atypes #29324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlining incorrectly computed the new atypes for an _apply call, leading to a cache miss and lack of inlining for call targets that are worth inlining for the given constant arguments, but not necessarily in general.
JeffBezanson
approved these changes
Sep 24, 2018
vtjnash
approved these changes
Sep 24, 2018
|
I'm secretly hoping that me properly rebasing on top of this will help in #28955 😛 |
|
Can we run Nanosoldier first on these type of PRs? |
|
Sorry, I should've done that. My bad. |
|
Tests appear to be unreliable? https://build.julialang.org/#/builders/16/builds/347/steps/8/logs/stdio |
jrevels
pushed a commit
that referenced
this pull request
Dec 31, 2018
Inlining incorrectly computed the new atypes for an _apply call, leading to a cache miss and lack of inlining for call targets that are worth inlining for the given constant arguments, but not necessarily in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlining incorrectly computed the new atypes for an _apply call,
leading to a cache miss and lack of inlining for call targets that
are worth inlining for the given constant arguments, but not necessarily
in general.