Bump Pkg3 #26696
Merged
Bump Pkg3 #26696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KristofferC
commented
Apr 4, 2018
KristofferC
commented
- Add credential handling to Pkg3's git functionality (thanks to @omus).
- Add a progress-bar for cloning repos, thanks @omus for the groundwork that made this feature possible (Support separate payloads for RemoteCallbacks #26437):
- Show in the Pkg3 prompt the name of the current project (also shown in gif above). Some users have been a bit confused about what their current project is, this should make that more explicit.
|
Weird, I can't reproduce that FreeBSD failure locally. @iblis17, have you seen that before? |
|
I saw it on recent master build. It only happened on one of worker. I'm going to detach it and check. |
|
@ararslan found a way to reproduce $ touch /tmp/test.magic
$ gmake -C test REPLThat test case is somewhat ... fragile. |
|
@iblis17: is the test case relevant to this PR or can I go ahead and merge this? |
|
Also, @KristofferC, is this good to go from your perspective? |
|
Looks like there are some |
That test case is irrelevant, and it has been solved. No idea why only BSD CI failed now. |
|
Because of new merges to master. |
* show a progress bar when cloning git repos and add credential handling (cherry picked from commit 1f8b80aa0942c9d481da7bb87646d02f6546d7f7)
(cherry picked from commit 5755370521a00d2c72d5388aa64b86605d6506d5)
(cherry picked from commit 88811b4091e3606fdd4a86d67538f32693345ee7)
KristofferC
force-pushed
the
kc/bump_pkg3_4
branch
from
eccae58 to
6afa037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.