-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Support rook-pivoting in bkfact #14389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(:csysv_,:csytrf_,:csytri_,:csytrs_,:Complex64, :Float32)) | ||
@eval begin | ||
for suffix in (symbol(""), :_rook) | ||
for (sysv, sytrf, sytri, sytrs, elty, relty) in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be simpler to have a loop for each function given the convoluted code just below.
Looks good to me except for the small style comment, maybe we should wait until #14309 has been merged. |
92dfc92
to
e0d68aa
Compare
e0d68aa
to
fe47de1
Compare
Rebased and updated, including the style change. Curiously, Travis never ran this as a PR (it did run the push), but AppVeyor did, so hopefully we're OK. |
Support rook-pivoting in bkfact
Required since #14389. [av skip]
It would be nice to make a bit more advertisement in the future when raising dependency requirements like that. It took me some time to realize why my EPEL RPM builds where failing. |
Since I always build openblas from source, I didn't think about this as a potential problem. Sorry about that, and thanks for fixing! |
You're welcome @timholy. |
Could this have been wrapped in a test for |
Seems like |
I seem to recollect that even BTW, I am ok with 3.5 being the minimum, but just wanted to point out the issues. |
One can probably work around missing LAPACK functions in MKL with some linker magic. One needs to link against MKL explicitly (i.e. using an |
LAPACK 3.5 supports alternative rook-pivoting algorithms for Bunch-Kaufman. This PR wraps this functionality.
Best reviewed with
?w=1
appended to the URL.