Improve type-stability of eigencopy_oftype
#1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As-is this can end up inferred as e.g.
`eigencopy_oftype(::Symmetric{ComplexF64, ...}, ::Type)::Matrix`
(eltype was lost)
This was referenced Aug 20, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1419 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 34 34
Lines 15852 15857 +5
=======================================
+ Hits 14881 14886 +5
Misses 971 971 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dkarrasch Is it simplest to just cherry pick this directly onto the release-1.12 branch, or should we do the backports? |
|
Usually one would want to run a CI check before merging/cherry-picking into a release branch, but this is simple enough to be cherry-picked directly, I think. |
dkarrasch
pushed a commit
that referenced
this pull request
Aug 21, 2025
Without the `where` clause, this can end up inferred / invoked as e.g.
`eigencopy_oftype(::Symmetric{ComplexF64, ...}, ::Type)::Matrix` (eltype
is lost)
dkarrasch
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
whereclause, this can end up inferred / invoked as e.g.eigencopy_oftype(::Symmetric{ComplexF64, ...}, ::Type)::Matrix(eltype is lost)