Skip to content

Pass find_similar kwargs to bm25 function #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Conversation

svilupp
Copy link
Collaborator

@svilupp svilupp commented Mar 6, 2025

  • Fixed find_similar to pass kwargs to bm25 to allow for normalization of scores

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (efdefaf) to head (041bab4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   89.61%   89.62%   +0.01%     
==========================================
  Files          12       12              
  Lines        1762     1764       +2     
==========================================
+ Hits         1579     1581       +2     
  Misses        183      183              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svilupp svilupp merged commit f9fb20a into main Mar 6, 2025
5 checks passed
@svilupp svilupp deleted the pass-kwargs-bm25 branch March 6, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant