Fix 5 arg mul! #253
Merged
Fix 5 arg mul! #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
tryBuild failed |
|
There's still an issue in Julia base to work around... I'll update the tests here s.t. that values don't get extremely high, but I would say ^ is a bug in LinearAlgebra, because it promotes to Int64. |
|
Can you retry? |
|
bors try |
|
bors d+ |
|
✌️ haampie can now approve this pull request. To approve and merge a pull request, simply reply with |
tryBuild failed |
haampie
force-pushed
the
fix-5-arg-mul!
branch
2 times, most recently
from
7a8cc3b to
64f4a1d
Compare
|
Oh sorry :/ I've tried it locally Final request to retry? 😅 |
|
After the |
tryBuild failed |
|
travis timed out bors try |
tryBuild succeeded |
|
bors r+ |
Build succeeded |
bors bot
added a commit
to JuliaGPU/CuArrays.jl
that referenced
this pull request
Mar 19, 2020
641: 5-arg mul! with 3-arg mul! support r=maleadt a=haampie Turns out I was not right about that static if for julia 1.3.0 (the relevant commit in base was merged before the release of 1.3.1, but only made its way into julia from 1.4.0-rc1). Otherwise this should work after JuliaGPU/GPUArrays.jl#253 is merged, because GPUArrays is stealing 3-arg mul! from CuArrays at the moment. Co-authored-by: Harmen Stoppels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from 3-arg mul to 5-arg mul to make sure GPUArrays's generic mul does not steal from CuArrays.
(Btw, I could not yet test because cyclops was unreachable :( )