Merged
Conversation
Member
|
Alright, thanks. We need to add a basic test for this function, given that we already made a mistake with it once. I don't think |
Contributor
Author
|
No it is not. I will incorporate it when adjusting the tests to the new PECUZAL version. This bugfix, however, might break the tests of the actual PECUZAL tests... |
Member
|
You can do both in this PR. |
Contributor
Author
|
perfect, I will. Thx |
revised PECUZAL method added
Member
|
Hi @hkraemer , please increment minor version in Project.toml, and also add an entry in CHANGELOG.md with a one-sentence description of changes users should be aware of. Then I'll merge and tag a new version. |
version increment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a minor bugfix for the function
hcat_lagged_values. The former version always reduced the length of the output Dataset by the given delay valueτ. Now it is just reducing the size according to the available data ins. @Datseris , you made it right in the implementation ofgenembedthough.