Improve is stochastic clause for automated TDE#78
Merged
Conversation
Member
Author
|
At the moment we just print a statement "Embedding not achieved." Shouldn't we error instead? |
Contributor
|
Jepp, we should return the time series, which has been put in, in this case and leave the message, I suggest. |
Member
Author
|
I'm asking whether the function should error instead of simply printing a message if a valid embedding has not been reached. |
Contributor
|
I suggest to let it print that message and return the single time series. Might be more handy in a loop-evaluation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hkraemer