Skip to content

Share docs with ChainRules #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2019
Merged

Share docs with ChainRules #21

merged 5 commits into from
Aug 12, 2019

Conversation

nickrobinson251
Copy link
Contributor

@nickrobinson251
Copy link
Contributor Author

I corrected the hypot examples following the correction made in JuliaDiff/ChainRules.jl#74

@nickrobinson251
Copy link
Contributor Author

nickrobinson251 commented Aug 12, 2019 •
edited
Loading

We do not (cannot?) actually run doctests because JuliaDiff/ChainRules.jl#82 (comment)

willtebbutt
willtebbutt approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM

@nickrobinson251 nickrobinson251 merged commit 15d7a4b into JuliaDiff:master Aug 12, 2019
@nickrobinson251 nickrobinson251 deleted the npr/use-chainrules-docs branch August 12, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtebbutt willtebbutt willtebbutt approved these changes

@oxinabox oxinabox Awaiting requested review from oxinabox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make only one set of docs for both ChainRules and ChainRules core?
2 participants
@nickrobinson251 @willtebbutt