Skip to content

add a way to break on throw #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2019
Merged

add a way to break on throw #253

merged 1 commit into from
Mar 31, 2019

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Mar 31, 2019

This is pretty useful when debugging the interpreter because it has quite a lot of try catches so when there is a bug in the interpreter, the catch messes up the stacktrace.

@codecov-io
Copy link

codecov-io commented Mar 31, 2019

Codecov Report

Merging #253 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   87.15%   87.17%   +0.01%     
==========================================
  Files          14       14              
  Lines        1985     1988       +3     
==========================================
+ Hits         1730     1733       +3     
  Misses        255      255
Impacted Files Coverage Δ
src/types.jl 84.12% <ø> (ø) ⬆️
src/breakpoints.jl 75.21% <100%> (+0.87%) ⬆️
src/interpret.jl 86.36% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7deef44...d8768dd. Read the comment docs.

@KristofferC KristofferC merged commit cef5350 into master Mar 31, 2019
@KristofferC KristofferC deleted the kc/break_on_throw branch March 31, 2019 17:06
timholy added a commit that referenced this pull request Apr 2, 2019
- Fix for change in CodeInfo.slotnames type on julia master (#251)
- Add a way to break on throw (#253)
- Exclude Union{} from is_vararg_type (#254)
- Various performance improvements (#254)
@timholy timholy mentioned this pull request Apr 2, 2019
timholy added a commit that referenced this pull request Apr 2, 2019
- Fix for change in CodeInfo.slotnames type on julia master (#251)
- Add a way to break on throw (#253)
- Exclude Union{} from is_vararg_type (#254)
- Various performance improvements (#254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants