Local completions #217
Local completions #217
Conversation
aviatesk
force-pushed
the
local-completions
branch
from
828dadd to
3944206
Compare
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 80.2% 80.26% +0.05%
==========================================
Files 8 8
Lines 672 679 +7
==========================================
+ Hits 539 545 +6
- Misses 133 134 +1
Continue to review full report at Codecov.
|
| # local completions | ||
| vars = filter!(locals(frame)) do v | ||
| # xref: https://github.com/JunoLab/Atom.jl/blob/master/src/debugger/stepper.jl#L411-L421 | ||
| if v.name == Symbol("#self") && (v.value isa Type || sizeof(v.value) == 0) |
There was a problem hiding this comment.
we may want to remove the latter filter conditions here.
There was a problem hiding this comment.
We have that in JuliaInterpreter as well but I am not sure I see the reason for it. I think it can be removed here anyway.
There was a problem hiding this comment.
hm, maybe @timholy knows that ?
There was a problem hiding this comment.
The #self is probably sufficient. It's not always there (I can't remember where I recently encountered such a situation), but it should be sufficient. Assuming I started that trend I was probably just being paranoid.
|
Thanks, this is a very nice enhancement. |
aviatesk
force-pushed
the
local-completions
branch
from
08cb5cc to
cbab584
Compare
Enables local completions in
julia_prompt