fix f and fr #101
Merged
fix f and fr #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 81.73% 82.25% +0.52%
==========================================
Files 7 7
Lines 427 434 +7
==========================================
+ Hits 349 357 +8
+ Misses 78 77 -1
Continue to review full report at Codecov.
|
fredrikekre
reviewed
Mar 19, 2019
| printstyled(stderr, "Not a valid frame index\n"; color=:red) | ||
| new_level = tryparse(Int, subcmds[2]) | ||
| if new_level == nothing | ||
| printstyled(stderr, "Failed to parse $(subcmds[2]) as an integer\n"; color=:red) |
There was a problem hiding this comment.
Suggested change
| printstyled(stderr, "Failed to parse $(subcmds[2]) as an integer\n"; color=:red) | |
| printstyled(stderr, "Failed to parse $(repr(subcmds[2])) as an integer\n"; color=:red) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92 and fixes #91
This puts a bit of source code from Base into the tests but that part hasnt been touched for years so should be ok.